create-dao icon indicating copy to clipboard operation
create-dao copied to clipboard

Support TypeScript

Open gaslimitreached opened this issue 3 years ago • 7 comments

It is possible to support TypeScript:

Steps:

  • create templates directory
  • rename template to default
  • move default to templates
  • create templates/typescript directory
    • will next/hardhat need separate directories due totsconfig.json?
  • update create-app.js for --typescript
    • install dependencies
    • copy templates/typescript assets

Reference for the steps above: create-next-app

gaslimitreached avatar Dec 11 '21 14:12 gaslimitreached

Why let people make non typescript projects at all? Nobody should be doing this in 2021 imo.

revmischa avatar Dec 11 '21 15:12 revmischa

correct, this is possible. I left code for the option of typescript install here https://github.com/Developer-DAO/create-dao/blob/0709815bf658dee5ae747c3591acea46003cb1e1/index.js#L20

and the code to copy the correct templated folder here https://github.com/Developer-DAO/create-dao/blob/0709815bf658dee5ae747c3591acea46003cb1e1/create-app.js#L138

I think the idea was to focus a working plain js version as a MVP and exploring ts later.

e-roy avatar Dec 11 '21 20:12 e-roy

I would volunteer to help migrate this project to TypeScript

carlomigueldy avatar Dec 12 '21 05:12 carlomigueldy

Should we add TypeScript for a template project?

berteotti avatar Dec 14 '21 12:12 berteotti

I would volunteer to help migrate this project to TypeScript

Go for it! Give me typescript or give me death.

revmischa avatar Dec 14 '21 13:12 revmischa

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

e-roy avatar Dec 14 '21 14:12 e-roy

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

Nicely done, please ping me here in this issue whenever it's ready to be migrated to TypeScript and hopeful I'm not gonna interfere the development cycle

carlomigueldy avatar Dec 15 '21 07:12 carlomigueldy