adding powerd by Vercel to footer and readme.md

[kempsterrrr]

This PR adds the Vercel logo to the Acamdemy foot per their requirements for sponsoring open-source projects here.

This does open an interesting question. If we also have a logo for the preferred RPC, is that too much or not.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
academy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 14, 2023 1:02pm

[kempsterrrr]

Linting / Type error - remove passHref and built locally.

error - ESLint: Failed to load plugin 'storybook' declared in '.eslintrc.cjs': Cannot find module 'eslint-plugin-storybook' Require stack: - /vercel/path0/__placeholder__.js Referenced from: /vercel/path0/.eslintrc.cjs
--
11:44:20.638 | Failed to compile.
11:44:20.638 |  
11:44:20.639 | ./components/footer/Footer.tsx:110:13
11:44:20.639 | Type error: Type '{ children: Element; href: string; passHref: true; isExternal: true; }' is not assignable to type 'IntrinsicAttributes & Omit<DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>, keyof LinkProps> & { ...; } & LinkProps & { ...; }'.
11:44:20.639 | Property 'passHref' does not exist on type 'IntrinsicAttributes & Omit<DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>, keyof LinkProps> & { ...; } & LinkProps & { ...; }'.
11:44:20.639 |  
11:44:20.639 | 108 \|               'https://vercel.com?utm_source=[developer-dao]&utm_campaign=oss'
11:44:20.639 | 109 \|             }
11:44:20.639 | > 110 \|             passHref
11:44:20.639 | \|             ^
11:44:20.640 | 111 \|             isExternal
11:44:20.640 | 112 \|           >
11:44:20.640 | 113 \|             <Image
11:44:20.686 | error Command failed with exit code 1.
11:44:20.686 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
11:44:20.705 | Error: Command "yarn run build" exited with 1

[okhaimie-dev]

This does open an interesting question. If we also have a logo for the preferred RPC, is that too much or not.

If it comes to it, I guess we can have a partners | sponsors section to contain the logo. They all don't have to be in the footer.

[Markkos89]

Hi @kempsterrrr ! I believe that is suggested to use Next.js Image component: https://nextjs.org/docs/pages/building-your-application/optimizing/static-assets for optimization, also you can use the image file from the public folder like this:

<Image src="/powered-by-vercel.svg" alt="something" width="64" height="64" />

Also in the docs suggests to explicity set the Image width and height

With the Link component from chakra you can use the "as" prop like it's used before, for example in the Privacy Policy link:

<Link as={NextLink} ...

Let me know if you need some help with this!

[kempsterrrr]

If it comes to it, I guess we can have a partners | sponsors section to contain the logo. They all don't have to be in the footer.

Agreed, particularly after chatting with @elPiablo - for Vercel it must be in the footer and the repo as they're dictating the terms to us. For our partners, we can be in control of those.

--

Thanks @Markkos89 - I'll try to find some time to update this PR today. I'll also add the required Logo in the readme.md file which I missed as well - thanks for the tips.

Tailwind > Chakra 😝

[vercel[bot]]

@kempsterrrr is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

[kempsterrrr]

I pushed an update but think I was being stupid and still used the Chakra UI Image component.

I also was not sure where to add the Vercel button to the readme.md file - maybe just a supports section at the bottom is good for now?

I'm really short on time so wont be able to look at this again until next week. If someone else wants to close out the PR then that's totally fine with me

[Markkos89]

I pushed an update but think I was being stupid and still used the Chakra UI Image component.

I also was not sure where to add the Vercel button to the readme.md file - maybe just a supports section at the bottom is good for now?

I'm really short on time so wont be able to look at this again until next week. If someone else wants to close out the PR then that's totally fine with me

Hey @kempsterrrr kemps! Do you want me to change the Image component and also add a Sponsors section at the bottom in the README file and add the Vercel banner? let me know! I can push a commit to this branch :smiley:

[okhaimie-dev]

Tailwind > Chakra 😝

Just here to support the motion that this is true. Nothing actually beats Tailwind + shadcn rn

[kempsterrrr]

I pushed an update but think I was being stupid and still used the Chakra UI Image component. I also was not sure where to add the Vercel button to the readme.md file - maybe just a supports section at the bottom is good for now? I'm really short on time so wont be able to look at this again until next week. If someone else wants to close out the PR then that's totally fine with me

Hey @kempsterrrr kemps! Do you want me to change the Image component and also add a Sponsors section at the bottom in the README file and add the Vercel banner? let me know! I can push a commit to this branch 😃

Yes, please. Would really appreciate that as I\m struggling for time 🙏🏻

[kempsterrrr]

@Markkos89 just pinging you to make sure you got the reply!!!

Never quite sure how well GitHub notifications work with/without tagging folks

[Markkos89]

@Markkos89 just pinging you to make sure you got the reply!!!

Never quite sure how well GitHub notifications work with/without tagging folks

Hey Kemps! :raised_hands:

Going to add this to the new branch, it is a small addition so no issue at all.

Let me know if this is okey and I will have it the loop.

Regards !! :muscle:

[kempsterrrr]

Can this PR be closed/rejected if this is being included in another branch @Markkos89 ?