Devance Joshi comments

Results 32 comments of


                                            Devance Joshi

[Feature Request]: Dedicated page displaying the compatibility of Electron versions with various operating systems.

Hey @erickzhao , I have created this sample page by writing a markdown file with mockup data. Look at this and please tell me if this is what you are...

Handle when documents are deleted

Hi. I think we can fix this by making changes in the sidebar.js file. Currently the file is statically taking references for the pages, I think I can write some...

Handle when documents are deleted

Hey, I'll take a look into this. Thank you

Config docs should include `npm install` commands

Hi, I will like to help on this if you allow.

fix(plugin-webpack): try other logger ports

Currently I am only checking till port 9009, @erickzhao can you guide me if we should increase the upper limit for this port availability checking.

fix(plugin-webpack): try other logger ports

Hi @BlackHole1, just made the changes that you suggested in code review and wrote unit tests for Logger.ts. I couldn't directly test the private functions such as portOccupied and findAvailablePort,...

fix(plugin-webpack): try other logger ports

Note: Currently one of the tests that I have written are dependent on port `49152` i.e if that port is occupied one my test will fail. We can get rid...

fix(plugin-webpack): try other logger ports

Hi Kevin, I just saw this. Working on it now!

fix(plugin-webpack): try other logger ports

Looking at the time the tests take, can you check my pr adding parallelism in circleci/config #3536.😁

fix(plugin-webpack): try other logger ports

Hey, I have fixed the CI errors in the previous merge from main.