638 Feature Request: password generator with options

[Christian-Oleson]

Pull request type

Feature Request

Please check the type of change your PR introduces:

• [ ] Bugfix
• [x] Feature
• [ ] UI change (please include screenshot!)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] Documentation content changes
• [ ] Internationalization and localization
• [ ] Other (please describe):

What is the current behavior?

N/a

Issue Number: 638

What is the new behavior?

A new password generator feature has been made. You can select

• Password Length
• To include lowercase characters
• To include uppercase characters
• To include special characters
• How many passwords to generate

Other information

• My first PR to this repo
• I am looking for initial feedback but may want to add Spanish and German translations to start, though I am unsure if you need all translations to be added up front.

Quality check

Before creating this PR, have you:

• [x] Followed the code style guideline as described in CONTRIBUTING.md
• [x] Verified that the change work in Release build configuration
• [ ] Checked all unit tests pass

[veler]

Hello, Thank you for this PR :D It looks great overall.

To give you some initial feedback and answer your questions:

1. No need to translate the tool yet. We use Crowdin (https://crowdin.com/project/devtoys), which will automatically pull the added strings from en-us in the main branch. That means we should first approve and merge this PR before doing the translation.
2. Since this is a new tool, we'd need to create a new icon for it. If you're willing to do it, you can try to follow the few instructions I left here: https://github.com/veler/DevToys/blob/main/assets/font/README.md Initially, these instructions were for me, as I'm not a pro a making icons and fonts. If you don't feel like doing the icon, let me know and I will happily do it. An idea of icon: how about something with *** or This icon comes from FluentSystemIcons-Regular (glyph F59E) which we could copy and/or edit since it's under MIT license.

[Christian-Oleson]

Hello, Thank you for this PR :D It looks great overall.

To give you some initial feedback and answer your questions:

1. No need to translate the tool yet. We use Crowdin (https://crowdin.com/project/devtoys), which will automatically pull the added strings from en-us in the main branch. That means we should first approve and merge this PR before doing the translation.
2. Since this is a new tool, we'd need to create a new icon for it. If you're willing to do it, you can try to follow the few instructions I left here: https://github.com/veler/DevToys/blob/main/assets/font/README.md Initially, these instructions were for me, as I'm not a pro a making icons and fonts. If you don't feel like doing the icon, let me know and I will happily do it. An idea of icon: how about something with *** or This icon comes from FluentSystemIcons-Regular (glyph F59E) which we could copy and/or edit since it's under MIT license.

I'll have to see if I can find another computer. FontForge is not liked by my machine it seems. I'll work to get it on another and see if I can follow the setup to generate a

[Christian-Oleson]

FYI, I'm still working this, just went out on parental leave last week, so it will take a bit longer than expected.

[veler]

FYI, I'm still working this, just went out on parental leave last week, so it will take a bit longer than expected.

@Christian-Oleson no worries :) I can address the remaining feedback myself if you'd like too. Also, congratulations for the newborn! 💯

[nj]

Might be good to extend further later on, perhaps with inspiration by https://randomkeygen.com/ (on GitHub at https://github.com/circlecell/randomkeygen.com, MIT licensed).

[Christian-Oleson]

FYI, I'm still working this, just went out on parental leave last week, so it will take a bit longer than expected.

@Christian-Oleson no worries :) I can address the remaining feedback myself if you'd like too.

Also, congratulations for the newborn! 💯

Thank you! It may be best to have you finish. I'm still out and a bit busy, so it may be best to get this released instead of having folks wait on me eventually completing this on my end.

[veler]

Closing this PR as the tool got completed into #873 . Thank you @Christian-Oleson and @micahmo for this contribution! :)