Gabriel Souza

Results 132 comments of Gabriel Souza

Did you try not use `CurrentScreen`, instead use `it.Content()` ? I did not see any reasoning why the used of the CurrentScreen in the `SlideTransition` block, can you elaborate on...

the `ScreenTransition` does the `saveableState` for you, there is no need to call `CurrentScreen` inside it.

I tested here and was not able to reproduce the state not being restored. ``` class BasicNavigationActivity : ComponentActivity() { @OptIn(ExperimentalVoyagerApi::class) override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) setContent { CompositionLocalProvider(...

Yeh, `LocalNavigatorScreenLifecycleProvider` is a new API that I did not have time to document currently. It did introduce a behavior change that was documented in the release notes that all...

@Tolriq the `NavigatorScreenLifecycleProvider` is the currently proper way to ScreenLifecycle to all screens at once. If you have custom implementation that depends on your custom screen parameters, etc, you can...

> Thanks for the help @DevSrSouza! Feels good to finally be able to update our dependencies. Sorry the delay to help with the issue. > Does this mean we don't...

> So it should work OOB with Android screen ? > > I need the viewmodels to be properly scoped to the screens and not the single activity and to...

> Edit: It would also be nice if we could scope a ViewModel to a Navigator, similar to how we can scope a ViewModel to a NavGraph with the Navigation...

@Tolriq `AndroidScreenLifecycleOwner` is now applied by default for all Screens in the Navigator. This is why AndroidScreen does not have any implementation anymore because is already applied. If you have...

@Tolriq Can you open an issue about that with a reproducible code and a reproducible way to validate that? As far I tested already, by using rememberSaveable is being restored....