IslamSakrak

Results 15 comments of IslamSakrak

what am I missing?

Try this out https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines

I have within the code added some code between comments and I was wondering would it be overengineering if I turned those to methods for readability and cleanness

> * Why are we using file attachments? Because message might be too long? If it's too long for embed, wouldn't it be too long for the command as well?...

I am not sure how to properly name this properly (since in the if statement already talks about what this code block do) or if it even needs to be...

> > and this piece of code from ChangeHelpCategoryCommand > > Good name, I know exactly what it represents. And most importantly, it's consistent with our naming scheme for similar...

This PR also seem to handle what #219 has mentioned so It should be linked?

> > This PR also seem to handle what #219 has mentioned so It should be linked? > > I think we will leave that issue for now, since use-case...

Is the code good to go? Do I need to fix anything beside the merge?

> Can you post some fresh demo images, want to see how's UI/UX looking ^^ It still looks the same as above