inventory-framework icon indicating copy to clipboard operation
inventory-framework copied to clipboard

Pagination#update doesn't update computed pagination

Open GliczDev opened this issue 10 months ago • 0 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

🐛 Describe the bug

Pagination#update doesn't update computed pagination, tho Pagination#forceUpdate works

✔️ Expected behavior

Pagination#update should update computed pagination

👣 Steps to Reproduce

Call update on a computed Pagination

💻 Platform

  • [x] Bukkit
  • [ ] Sponge
  • [ ] Other

⭐ Server Version

1.21.4

📚 Library Version

3.2.0

✍️ Additional context

https://github.com/DevNatan/inventory-framework/blob/b1147857970af3a803ebbf33f61312bbdf61cd56/inventory-framework-core/src/main/java/me/devnatan/inventoryframework/component/PaginationImpl.java#L419 also checking isComputed in this line would work, but I'm not sure if that would be a correct implementation

GliczDev avatar Feb 23 '25 01:02 GliczDev