Valentin Mariette

Results 12 comments of Valentin Mariette

Thanks, will take a look at this !

I finally had a bit of time to look into this. The backoff crate looks like the right choice for the task. The only pain point is using an async...

> I guess I would say can you give me more information on how it would be used? Is the ranomization factor based off of the backoff crate? I didn't...

```rust struct ThrottleConfig; #[derive(Clone, Debug)] pub enum Retries { NoRetry, ExponentialBackoff(ExponentialBackoffConfig), Throttle(ThrottleConfig), } #[derive(Clone)] struct ClientConfiguration { access_token: Option, headers: HeaderMap, referer: bool, timeout: Option, retries: Retries, connect_timeout: Option, connection_verbose:...

I like your pipeline approach. Might be especially usefull when trying to follow the Microsoft RFC for retries and the user's needs. > The graph api throttles the amount of...

I was trying to implement the Http Pipeline and I encountered a few problems. First of all, contrary to something like a tower middleware, I don't think it's possible to...

I just pushed a commit to implement the HTTP Pipeline. A lot of work is still needed (give user ability to customize pipeline policies, implementing max number of retries, RequestContext,...

Sorry It took me so long to reply, was in vacations. > Ok so there is a good bit there and I think its a good start. There were a...

> > That was actually one of the first thing I look when I started the implementation because I use Axum with a custom middleware for a project. I don't...

I just pushed a rewrite of the pipeline to use Tower and it's services. 2 retries strategies are implemented : by number of attemps and waiting for the delay specified...