devextreme-reactive icon indicating copy to clipboard operation
devextreme-reactive copied to clipboard

Additional aria-labels (MUI)

Open jmannDev43 opened this issue 6 years ago • 3 comments

I'm using ...

  • [x] React Grid
  • [ ] React Chart
  • [ ] React Scheduler

Description

Is it possible to add an aria-label to the TableDetailToggleCellBase Material-UI component?

Thanks in advance!

jmannDev43 avatar Mar 29 '19 19:03 jmannDev43

Hi @jmannDev43

You can use TableRowDetail.toggleCellComponent to implement your task. Here's an example project.

ushkal avatar Apr 01 '19 07:04 ushkal

Hi ushkal, Thanks for the quick response.

I understand that I can implement my own version, (and I have done that with other components, such as the TableFilterRow cellComponent), where making the component accessible is somewhat more involved, but in this case isn't it a matter of just adding an aria-label to the IconButton here https://github.com/DevExpress/devextreme-reactive/blob/master/packages/dx-react-grid-material-ui/src/templates/table-detail-toggle-cell.jsx#L43?

It seems analogous to https://github.com/DevExpress/devextreme-reactive/pull/1906.

jmannDev43 avatar Apr 01 '19 12:04 jmannDev43

Also, (I just realized), in the example project, the aria-label is added to the TD component rather than the icon button (which is what triggers an accessibility audit error for us).

Thanks again,

jmannDev43 avatar Apr 01 '19 22:04 jmannDev43