AjaxControlToolkit icon indicating copy to clipboard operation
AjaxControlToolkit copied to clipboard

AjaxControlToolkit.HtmlEditor.Sanitizer nuget package missing dependency on AjaxControlToolkit package

Open kberridge opened this issue 4 years ago • 0 comments

The AJAX Control Toolkit 20.1.0

The AjaxControlToolkit.HtmlEditor.Sanitizer nuget package seems to be missing a dependency on the AjaxControlToolkit package. I had the impression that the AjaxControlToolkit.HtmlEditor.Sanitizer would be able to be used on it's own without AjaxControlToolkit (which is what I wanted) so I installed that nuget, but then I got a runtime assembly load error because IHtmlSanitizer is defined in AjaxControlToolkit and is depended on by AjaxControlToolkit.HtmlEditor.Sanitizer. Installing the AjaxControlToolkit nuget fixes the problem. So I think the AjaxControlToolkit.HtmlEditor.Sanitizer nuget package should be published with the metadata that says it depends on AjaxControlToolkit. Then if you install AjaxControlToolkit.HtmlEditor.Sanitizer nuget will also install AjaxControlToolkit and you wont get the runtime error.

The installation method

  • [ ] Installer
  • [x] NuGet package
  • [ ] A custom build from the source code

Minimal steps to reproduce the bug

  1. Nuget install ONLY AjaxControlToolkit.HtmlEditor.Sanitizer
  2. Write some code that uses the sanitizer
  3. Run it

Actual result

Runtime exception trying to load IHtmlSanitizer type from AjaxControlToolkit.dll, which is not found.

Expected result

Should install all required dependencies.

kberridge avatar Dec 03 '20 16:12 kberridge