cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: exclude context lines from git diff

Open maxnowack opened this issue 1 year ago • 1 comments

If there are more than 0 lines of context returned by `git diff', the CLI will also detect these context lines as changes, even though these lines have not been modified. I noticed this bug while using the feature-flag-pr-insights-action. Some pull requests were commented by the action with variable changes (added and removed at the same time, but that is another issue), but the variables were not touched in the PR.

maxnowack avatar Aug 03 '23 10:08 maxnowack

Hey @maxnowack, we rely on the context lines to help us find matches. For example, if a call to the variable method was split across multiple lines and only one was modified, we'd still consider that a change.

         this.dvcClient.variable(
             user,
-            'variable-key',
+            'new-variable',
             true
         )

For the case where the variable call wasn't changed at all, I'm testing with this diff and seeing the expected output, can you provide more details or a code snippet for the case you're describing?

laurawarr avatar Aug 04 '23 14:08 laurawarr