zero-to-nix icon indicating copy to clipboard operation
zero-to-nix copied to clipboard

Add funny joke to shell hook example

Open 3Rafal opened this issue 2 years ago • 3 comments

Hello, In Guide 4 I was ordered to:

Run this to see an example shell hook: nix develop "github:DeterminateSystems/zero-to-nix#hook" Nix development environments support environment variables as well. Run echo $FUNNY_JOKE to access a (hilarious) value that's available only in the Nix environment.

The problem is that only #example shell sets this variable and it doesn't work in #hook shell. This PR makes above example work.

3Rafal avatar Feb 03 '23 03:02 3Rafal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
zero-to-nix ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 3:18AM (UTC)

vercel[bot] avatar Feb 03 '23 03:02 vercel[bot]

@3Rafal I'm gonna think on this a bit. I think that the proper solution here may be to restructure that doc. I basically inserted some new content about shell hooks in a way that didn't fit with the rest of the narrative. Mea culpa! If I end up closing this, please know that it wouldn't be because I think this is "wrong" in any way 😄

lucperkins avatar Feb 03 '23 19:02 lucperkins

@lucperkins , no worries! I had fun tinkering with this project, so even if it's not merged I still learned a lot. Thanks for your effort! 😊

3Rafal avatar Feb 03 '23 20:02 3Rafal