DeterminateSystems
feat: support signoff option
Description
This PR add support for the signoff options supported by the Peter Evans's create-pull-request action
Checklist
- [x] Tested functionality against a test repository (see "How to test changes")
- [x] Added or updated relevant documentation (leave unchecked if not applicable)
@cole-h Thank you for the review and for spotting the error in the readme 😄 Can you approve it now?
Oh I see, I missed that!. What if we do remove the --commit-lock-file option from nix.ts, and we let the create-pull-request action take care of that?
I played a bit with the action, and I finally make it work using create-pull-request action instead of using nix:
https://github.com/andrea11/update-flake-lock-test/pull/3/commits
What do you think about this approach?
Hi again @cole-h, I noticed that with my previous changes the flake update output went lost. I updated once more, to get something similar to what we had before:
Before:
After:
The output is not exactly the same as before, because I am using the output from nix flake update command rather and then delegate the commit to the github action create-pull-request.
Let me know if you consider this blocking
@cole-h Any news on this PR? If it is too "complicated" or it has too many changes, let me know. I wanted to tackle this one before #200