Question: if `flake update` fails, is PR created?

Open peterbecich opened this issue 1 year ago • 1 comments

Thanks for this great GitHub Action. I haven't tested it yet.

What happens if flake update fails? Will the PR still be created?

An example is the hackage-server flake.nix. Right now, nix flake update will fail because the Flake is incompatible with current NixPkgs.

Additionally, building on https://github.com/DeterminateSystems/update-flake-lock/issues/91, can additional checks be specified that would prevent the PR from being created?

Assuming the PR is created regardless of flake update success or failure, a broken flake.nix can be caught by other GitHub Action tests on the flake. However, there may be a lot of automated and broken PRs sitting in the list.

Jul 14 '24 07:07 peterbecich

I think I've answered my own question; no:

https://github.com/DeterminateSystems/update-flake-lock/blob/db4ee38117a597ea8df8f7f75a187dd65093eade/src/index.ts#L65

Jul 14 '24 09:07 peterbecich