update-flake-lock icon indicating copy to clipboard operation
update-flake-lock copied to clipboard

PR body uses hardcoded branch name

Open srid opened this issue 1 year ago • 1 comments

The branch name update_flake_lock_action is hardcoded here:

https://github.com/DeterminateSystems/update-flake-lock/blob/222f041780a88f7f379bd7a3c3327585e435db5b/action.yml#L47-L51

But this becomes incorrect, when the user overrides it in the workflow YAML as I do here. This results in creating PRs with wrong instructions:

https://github.com/srid/haskell-flake/pull/321

The PR body refers to branch update_flake_lock_action contradicting the actual branch update_flake_lock_example.

srid avatar May 26 '24 15:05 srid

Aside: I wrote this little Nu script to automate the steps, taking the PR URL directly.

https://github.com/srid/nixos-config/commit/db392e491722722fdb687f6da698e42492423fb2

srid avatar Aug 04 '24 22:08 srid