flake-checker icon indicating copy to clipboard operation
flake-checker copied to clipboard

missing input deps is a println!, not fatal error

Open colemickens opened this issue 1 year ago • 4 comments

Some flakes don't have nixpkgs, be a bit more accepting of them.

colemickens avatar Jun 21 '24 22:06 colemickens

@colemickens The tool does currently enable you to supply a specific set of Nixpkgs keys via --nixpkgs-keys. I'd prefer to keep the current behavior.

lucperkins avatar Jun 21 '24 22:06 lucperkins

@lucperkins for context, this is for testing with DeterminateSystems/ci.

Not having this would imply needing another option for ci to teach it about what branches to check. I'd be curious for @grahamc's thoughts on that.

colemickens avatar Jun 21 '24 22:06 colemickens

For now, I can probably set NIX_FLAKE_CHECKER_NIXPKGS_KEYS for my parent workflow...

colemickens avatar Jun 21 '24 23:06 colemickens

The issue is that there's always an expected set of Nixpkgs input keys. The default is ["nixpkgs"] but you can override that. With the behavior proposed in this PR, Flake Checker would simply successfully exit if none of the provided keys actually were Nixpkgs inputs, which would be surprising behavior, I think.

lucperkins avatar Jun 21 '24 23:06 lucperkins