basedpyright icon indicating copy to clipboard operation
basedpyright copied to clipboard

basedpyright should also do syntax highlighting

Open DetachHead opened this issue 1 year ago • 3 comments

currently the semantic highlighting assumes your editor already does the basic syntax highlighting, but vscode's sucks because it uses an abandoned 3rd party package (https://github.com/microsoft/pylance-release/issues/5824)

this would address all issues labelled with https://github.com/DetachHead/basedpyright/labels/vscode%20syntax%20highlighting, along with this neovim syntax highlighting issue with match statements that was raised in the discord:

image

probably also need to figure out #147, as there are two different colours used (in vscode at least) for keywords and i'm not sure what the distinction between them is supposed to be

DetachHead avatar Sep 22 '24 04:09 DetachHead

I'm not sure if this is the right place, but match also has problems with syntax highlighting in vscode image

UPDATE: It seems to be a problem with the MagicPython plugin, disabled and back to normal, but it is normal to use Pylance and MagicPython at the same time.

shoucandanghehe avatar Oct 12 '24 15:10 shoucandanghehe

magicpython is bundled with vscode and also hasn't been updated in ages (see https://github.com/microsoft/pylance-release/issues/5824). match statements look fine for me so i assume the extension you're using has gone even longer without an update than that version

DetachHead avatar Oct 12 '24 21:10 DetachHead

I personally prefer only using semantic highlighting with basedpyright. If this feature is added, I hope it is configurable.

kiyoon avatar Mar 25 '25 07:03 kiyoon

Still no syntax highlighting. Unfortunately, it's unusable.

Image

Axibord avatar May 31 '25 12:05 Axibord

that looks like syntax highlighting is working but semantic highlighting isn't. are you sure you have basedpyright enabled and not pyright?

DetachHead avatar Jun 01 '25 06:06 DetachHead