basedpyright icon indicating copy to clipboard operation
basedpyright copied to clipboard

primer results for sympy and spack are flaky

Open DetachHead opened this issue 1 year ago • 3 comments

there are differences on changes that don't touch type checking code at all. as far as i can tell some upstream change has caused some sort of flake that causes it to have different results on each run. some examples:

  • https://github.com/DetachHead/basedpyright/pull/561#issuecomment-2282671093
  • https://github.com/DetachHead/basedpyright/pull/560#issuecomment-2282347113
  • https://github.com/DetachHead/basedpyright/pull/514#issuecomment-2271143954

worth noting that i think the reason these don't show up on upstream primer comments is because most rules arent enabled on the upstream repo (which seems to cause a lot of bugs that go undetected)

DetachHead avatar Aug 11 '24 08:08 DetachHead

same with spack, but those are more rare: https://github.com/DetachHead/basedpyright/pull/608#issuecomment-2366058427

DetachHead avatar Sep 22 '24 08:09 DetachHead

upstream issue: https://github.com/microsoft/pyright/issues/10039

DetachHead avatar Mar 15 '25 23:03 DetachHead

interestingly the primer currently does not actually run with --threads as far as i can tell, despite what the title and description on the upstream issue says (see https://github.com/DetachHead/basedpyright/pull/1239/commits/1515eec4e3d213eafac4a9345fc1ed27ca1fee91 where i turned it on because i'm currently experimenting with --threads to see whether logical or physical cores is a better default)

DetachHead avatar Apr 19 '25 13:04 DetachHead