basedpyright icon indicating copy to clipboard operation
basedpyright copied to clipboard

Make sure the license is golden

Open KotlinIsland opened this issue 2 years ago • 3 comments

KotlinIsland avatar Jan 23 '24 23:01 KotlinIsland

it's MIT so i'm pretty sure it's fine

DetachHead avatar Jun 10 '24 22:06 DetachHead

i was under the impression that you're supposed to just keep the license as-is when forking a project, and any changes would need approval from everybody who has ever contributed to the project, but @decorator-factory pointed out that this isn't exactly true:

https://opensource.stackexchange.com/a/7917 it could be changed to something like

MIT License

Basedpyright
Copyright (c) Basedpyright maintainers

Basedpyright is a fork of Pyright, created by Microsoft Corporation and licensed under the MIT license.
Pyright - A static type checker for the Python language
Copyright (c) Microsoft Corporation. All rights reserved.

..<rest of the file>

A fork is just a specific kind of a derivative work. Essentially, you're using code provided by Microsoft in your own work. So you have to follow the terms of the license: namely, retain the text of the license and make it clear which parts you borrowed

I think ...something needs to change, because we don't want to misrepresent this as being a Microsoft product

re-opening this for further investigation

DetachHead avatar Oct 15 '25 00:10 DetachHead

IANAL btw

decorator-factory avatar Oct 15 '25 00:10 decorator-factory