`exclude` and `ignore` should be merged into one option, and `include`/`exclude` documention should be updated to say that it's only relevant in the language server when `diagnosticMode` is set to `"workspace"`
workaround: use ignore instead
whats even the difference between these 2 options? one of them should be deleted i think
whats even the difference between these 2 options? one of them should be deleted i think
https://docs.basedpyright.com/#/configuration?id=main-configuration-options
- exclude [array of paths, optional]: Paths of directories or files that should not be considered part of the project. These override the includes directories and files, allowing specific subdirectories to be excluded. Note that files in the exclude paths may still be included in the analysis if they are referenced (imported) by source files that are not excluded.
- ignore [array of paths, optional]: Paths of directories or files whose diagnostic output (errors and warnings) should be suppressed even if they are an included file or within the transitive closure of an included file. Paths may contain wildcard characters
i think this difference isn't relevant in vscode, so the setting should be removed from the vscode/lsp settings but still allowed in the cli maybe
i think exclude and include are only relevant for the vscode extension when basedpyright.analysis.diagnosticMode is set to "workspace", because when it's set to "openFilesOnly", those open files are always included. maybe the documentation just needs to be updated to make this clear
oh also if you only use ignore but not exclude, the cli wastes time analyzing the ignored files even though it's not going to show any of its diagnostics. ignore should just imply exclude as well.
actually come to think of it, what's even the use case for excluding files but not ignoring their errors? maybe i was right in my first post that both options aren't needed