basedpyright icon indicating copy to clipboard operation
basedpyright copied to clipboard

Published 20 hours ago • verified publisher icon DetachHead

use bun instead of node

Open DetachHead opened this issue 11 months ago • 3 comments

fixes #60

potentially also fixes these issues - need to confirm with the people who raised them:

  • #177
  • #172
  • #167

DetachHead avatar Mar 25 '24 07:03 DetachHead

There are any performance benchmarks for that replacement?

divaltor avatar Mar 26 '24 22:03 divaltor

i measured how long it took to run pyright 100 times with both node and bun and it was only a few seconds faster lol. the main reason i wanted to try this was to see if it would fix any of the issues people had with the bundled node, but tbh it will probably cause more problems than it'll solve. can't even get bun install to work

DetachHead avatar Mar 26 '24 22:03 DetachHead

Few seconds still is nice. Would be nice to see more detailed benchmark with hyperfine or similar tool. Good job

divaltor avatar Mar 27 '24 06:03 divaltor

all of the issues mentioned in the OP have been resolved (except #177 which is just pending some documentation), so i don't really see much point in doing this anymore, especially since there was pretty much no performance gains. can re-visit in the future if that changes

DetachHead avatar Jun 18 '24 13:06 DetachHead