basedpyright icon indicating copy to clipboard operation
basedpyright copied to clipboard

enable `reportIncompatibleUnannotatedOverride` and disable `reportUnannotatedClassAttribute` by default

Open DetachHead opened this issue 4 months ago • 4 comments

we should probably just switch to having reportIncompatibleUnannotatedOverride enabled by default instead. i've been using it for ages and haven't noticed any performance issues with it

Originally posted by @DetachHead in #1208

DetachHead avatar Oct 24 '25 02:10 DetachHead

i've been using it for ages and haven't noticed any performance issues with it

i think it's a potential issue, perhaps we should update the error message to warn?

KotlinIsland avatar Oct 24 '25 02:10 KotlinIsland

how would that impact performance?

DetachHead avatar Oct 24 '25 02:10 DetachHead

how would that impact performance?

reportIncompatibleUnannotatedOverride potentially impacts performance, i don't get what you are asking

KotlinIsland avatar Oct 24 '25 03:10 KotlinIsland

nvm, i thought you were suggesting updating the diagnostic category from error to warning

DetachHead avatar Oct 24 '25 09:10 DetachHead