DIM icon indicating copy to clipboard operation
DIM copied to clipboard

Published 20 hours ago • verified publisher icon DestinyItemManager

[Finisher] text in description

Open bhollis opened this issue 1 year ago • 3 comments

Do we need to do something to support this in RichDestinyText?

Screenshot 2023-09-02 at 7 21 12 PM

bhollis avatar Sep 03 '23 02:09 bhollis

I don't think so - the game replaces [Finisher] (or whatever the D2-internal string is, [Finisher] seems to be an invention of the Bungie.net API) at runtime with whatever button (combo) is mapped to the Finisher button. Some others can be found in

https://github.com/DestinyItemManager/DIM/blob/6608569677220f9e77fb176883bdf7ba05a8a475/src/data/d2/symbol-name-sources.ts#L875-L890

(Finisher isn't there, I guess the symbols code isn't looking at item descriptions)

robojumper avatar Sep 03 '23 08:09 robojumper

stasis locked glyphs are there in the font actually image

nev-r avatar Sep 07 '23 04:09 nev-r

Right, I think I had some problems localizing those and skipped them because of that.

robojumper avatar Sep 09 '23 10:09 robojumper