DIM
DIM copied to clipboard
Can you add the Browser and OS information below the DIM version?
Proposed change
Can you add the Browser and OS information below the DIM version?
How does this fit into your workflow?
That would simplify bug submissions, and you'd be more likely to get the accurate information you want.
I guess? I think most people know what browser and OS they use?
I use DIM on Safari, Chrome and Firefox on my Mac, Edge on my XBox, Safari, Chrome and App Store apps on my iPhone and iPad. I know what platform and browser I'm on, but I like to double check system versions when submitting bug reports and I usually don't know what browser version I'm on. 😀
I figured I would take this as my first issue since it seems easy enough. Not sure where a good spot would be to put the info though. Do you guys think just here on the about page is fine or does somewhere else make more sense?
Yeah, it could go right below the version on that page
is this chrome or safari though
That screenshot is from chrome. For some reason, on chromium based browsers it shows both chrome and safari in the printout. If the user were using Firefox for example it should only say Firefox. As a result of this, there is also no way (as far as I can tell) to see if the user is on a chromium based browser that isn't chrome. (like Brave). I could add some type of method to parse the value of userAgent if you feel it is necessary
Maybe we should use our user agent parser library
Thanks, I didn't realize there was already a library installed to deal with this sort of thing. I updated the PR a bit. I'm importing the library that I hope you were talking about. I'm not really familiar with typescript, and my editor was yelling at me about not having types for that library installed, so I ran an npm command to install them, and it added to the package.json. Let me know if I shouldn't have committed that along with the actual change