DIM
DIM copied to clipboard
Loadouts / Loadout Optimizer mostly don't check Subclass Fragment capacity
- [ ] It's possible to have a subclass in-game with aspects allowing 3 fragments but 4 fragments equipped. The fourth fragment is simply disabled and has no effect, but creating a Loadout from equipped takes those 4 fragments even though it's not a valid setup.
- [ ] Even with a valid Loadout subclass setup, it's trivial to switch from 4 fragment capacity to 3 without fixing up fragments and end up with an invalid setup.
- [ ] Loadouts and LO will treat stats from excess fragments as active without any indication that the setup is invalid. Contrary to armor mods, which have the mod assignment drawer listing unsassigned mods, and LO refusing to show armor sets if the mods don't fit, subclass config has no indication in the Loadout drawer or LO that the capacity isn't there, so Loadouts and LO will calculate with stats the user considers wrong.
Creating socket overrides from the equipped subclass should check energy capacity, Loadouts and LO should indicate when fragments are invalid and not honor their stats.
(The only place where capacity is being checked is in the Subclass Plug drawer, so that should be extended.)
Edit: Actually, maybe silently eating stats isn't great either... probably just needs a better indication.
Related to #8139.
So #8348 and #8350 were supposed to tackle this, but it's been unclear how much of this we actually want:
- On one hand, subclasses with no aspects active also don't have any active fragments, so it's sort of wrong to consider them active and take their stats into account in Loadouts.
- On the other, Loadouts can just specify fragments and no aspects, and rely on the pre-existing aspects to provide enough capacity, "disabling" the fragments would also be wrong in this situation.
- Finally, third-party sites like D2ArmorPicker may generate Loadout links with fragments for stats but no aspects picked, not taking fragments into account when receiving such links would be quite annoying for people who load their D2AP set into LO.
- Drawing a comparison to Loadout mods, we also don't check which mods we can fit -- we honor all their stats, and have the mod assignment drawer to tell people what doesn't fit when they find they can't apply the loadout in its entirety.
So I'm tending towards honoring all stats, and finding a non-intrusive way to indicate that there are more fragments than capacity. I think my PR #8350 was actually too heavy-handed, picking a random subset of fragments, dimming them and removing their stat contributions is unlikely to be useful.
We've fixed the bug where adding a subclass to a loadout immediately copied disabled fragments, we now show warnings on the Loadouts page for ill-configured subclasses, and I think we've agreed that randomly not including some stats would be more astonishing. I think this is done.