DIM icon indicating copy to clipboard operation
DIM copied to clipboard

Published 20 hours ago • verified publisher icon DestinyItemManager

Enhanced weapon trait styling

Open vivekhnz opened this issue 2 years ago • 4 comments

With the introduction of weapon shaping, weapons can now have Enhanced Traits. These are styled slightly differently and we should reflect that in DIM:

  • Update perk 'bubbles' in the item popup (both list & grid) and armory views to include a yellow (#f3cf55) arrow intersecting with the left edge of the bubble and a yellow linear gradient at the bottom of the bubble (see in-game perk bubble)
  • When the item popup is displayed in perk list mode, style the separator line above an enhanced trait 'row' as a yellow line + gradient to match the in-game item tooltip. Note that shaped weapons cannot currently have multiple perk choices in the same column, so we don't need to worry about having a mix of non-enhanced and enhanced traits in the same column.
  • Update the Perks, Mods & Shaders and Weapon Traits columns in Organizer to display a yellow arrow to the left of enhanced traits (see in-game item tooltip)
  • Style the item subtype text in the perk PressTip to match the in-game perk tooltip for enhanced traits

See below for reference screenshots: dim-enhanced-traits-reference

vivekhnz avatar Mar 02 '22 11:03 vivekhnz

Regarding my comment regarding the yellow horizontal line above enhanced traits:

Note that shaped weapons cannot currently have multiple perk choices in the same column, so we don't need to worry about having a mix of non-enhanced and enhanced traits in the same column.

It seems like Adept weapons from Vow of the Disciple (Master difficulty presumably) will be able to drop with Enhanced Traits based on their perk pools. If they can also drop with multiple perks in the same column (as was the case for Timelost weapons from Master difficulty Vault of Glass), we would need to account for a having a mix of non-enhanced and enhanced traits in the same column.

vivekhnz avatar Mar 09 '22 11:03 vivekhnz

i am not of the opinion we need this styling image

for 1, it's hideous, for 2, we aren't braytech

nev-r avatar Mar 11 '22 05:03 nev-r

Yep, fair enough. I think what we have in beta looks good so will close this.

vivekhnz avatar Mar 11 '22 07:03 vivekhnz

i was leaving it open because it's not yet implemented in organizer, and possibly other places, haven't really done a thorough sweep

nev-r avatar Mar 11 '22 07:03 nev-r