DIM icon indicating copy to clipboard operation
DIM copied to clipboard

is:wishlist not matching on Belisarius-D

Open philkernick opened this issue 1 year ago • 4 comments

DIM Version

current beta

Browser Details

chrome

OS Details

Windows 11

Describe the bug

I have a Belisarius-D that has a 5/5 match with a wishlist role.

dimwishlist:item=2313726158&perks=839105230,1561002382,3619207468,460017080,3465198467

image

image

However there is no wishlist thumbs up on the item, and it is not selected by is:wishlist.

image

Logs

No response

philkernick avatar Feb 04 '24 09:02 philkernick

Can you share your profile export? Are you using the default voltron wishlist?

bhollis avatar Feb 10 '24 20:02 bhollis

Yes, default voltron wishlist. Not sure how to share a profile export.

The only thing I can see that is different about that weapon is that the 5th column perk is in the wishlist. And it's the only weapon I can find that the 5th column perk is selectable betwen an origin trait and a stock.

philkernick avatar Feb 11 '24 01:02 philkernick

A profile export can be saved from the Settings page in beta, at the bottom.

bhollis avatar Feb 17 '24 01:02 bhollis

Profile attached.
profile-data.json

philkernick avatar Feb 17 '24 08:02 philkernick

I loaded up the profile export, and I see two Belisarius-D that both match the wish list and have a thumbs up. Are you still seeing this issue?

bhollis avatar May 24 '24 05:05 bhollis

I only have one Belisarius-D, which is strange. But yes, the issue remains, and it continues to be the only weapon that has this problem. Current beta.

philkernick avatar May 24 '24 09:05 philkernick

Hmm, interesting. I've got the default Voltron list loaded, and with your profile info from February I see two Belisarius, both of which have a thumbs up (one is masterworked and one is not).

For fun, can you go to Settings, uncheck the default Voltron wishlist, and re-check it?

bhollis avatar May 24 '24 19:05 bhollis

I unchecked Voltron, clicked clear wishlist, then recheckedc Voltron. Same problem. All the other wishlist items are correct, but not Belisarius.

And I really only have one of them.

image

philkernick avatar May 25 '24 01:05 philkernick

submit a new profile data

delphiactual avatar May 25 '24 01:05 delphiactual

New profile attached. profile-data.json

philkernick avatar May 25 '24 02:05 philkernick

Loading that profile, I see this:

Screenshot 2024-05-25 at 11 46 55 AM

bhollis avatar May 25 '24 18:05 bhollis

Oh, interesting, that seems to be matching from the Just Another Team wishlist. Just voltron doesn't match.

bhollis avatar May 25 '24 18:05 bhollis

OK, solved:

https://github.com/48klocs/dim-wish-list-sources/blob/f7414f3a29237eb8f37e506f2372ae6f36497c6e/PandaPaxxy/panda_s23_vendor.txt#L89-L220

The PandaPaxxy rolls for Belisarius-D specify that the roll must include Composite Stock AND Hand-Laid Stock AND Short-Action Stock. Obviously, that's impossible. @48klocs it looks like we need some validation on these rolls.

bhollis avatar May 25 '24 18:05 bhollis

Closing, see linked issue https://github.com/48klocs/dim-wish-list-sources/issues/189

bhollis avatar Jun 20 '24 01:06 bhollis