shards-react icon indicating copy to clipboard operation
shards-react copied to clipboard

Allow tag to be a component

Open sammy2077 opened this issue 5 years ago • 2 comments

When i pass a component as a tag to supported element like Nav

import { Link } from 'react-router-dom';

<NavbarBrand tag={Link} to="/">
          Agweria
</NavbarBrand>

I get the error : Failed prop type: Invalid prop tag supplied to NavbarBrand See console error

image

Though it works fine even in the above case, is there a way to get rid of the console error.

See . https://github.com/facebook/prop-types/pull/211

sammy2077 avatar Nov 23 '19 18:11 sammy2077

I am also experiencing this problem, which happened when I upgraded React-router-dom to the latest version 5.1.2.

jorgeotavio avatar Dec 02 '19 16:12 jorgeotavio

Anything updates on this? @design-revision

bvanhou avatar Mar 13 '20 16:03 bvanhou