Descent3 icon indicating copy to clipboard operation
Descent3 copied to clipboard

DallasFuncs pokes

Open MaddTheSane opened this issue 9 months ago • 6 comments

Pull Request Type

  • [ ] GitHub Workflow changes
  • [ ] Documentation or Wiki changes
  • [ ] Build and Dependency changes
  • [X] Runtime changes
    • [ ] Render changes
    • [ ] Audio changes
    • [ ] Input changes
    • [ ] Network changes
    • [X] Other changes

Description

This sets all the functions and variables in DallasFuncs.cpp as static, as well as marking them all with [[maybe_unused]]. marking functions and variables as static means that they won't be exported as public symbols by the included source files, and [[maybe_unused]] is because not every plug-in uses all the functions in DallasFuncs.cpp. As DallasFuncs.cpp is included in the scripts files themselves and not build individually, this shouldn't cause any issues.

Checklist

  • [X] I have tested my changes locally and verified that they work as intended.
  • [X] I have documented any new or modified functionality.
  • [X] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • [X] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

MaddTheSane avatar May 14 '24 01:05 MaddTheSane