Descent3
Descent3 copied to clipboard
Convert iso-8859-1 encoded files to UTF8 encoding
The following script was used convert the file encodings.
for filename in $(find)
do
encoding=$(file -b --mime-encoding $filename)
if [ "$encoding" = "iso-8859-1" ]; then
iconv -f iso-8859-1 -t utf8 ${filename} -o ${filename}.utf8
mv ${filename}.utf8 ${filename}
fi
done
Converting non-English messages may break them in game. Need test it on runtime.
- I recommend putting
fixes #145
into the description of this pull request so that that issue automatically gets closed when this PR is merged.- I think that you should split this change into two different commits, one that converts things to UTF-8, and one that switches to LF line endings. We may find a bug in the future that is caused by switching to UTF-8, but not caused by switching to LFs. If we do end up finding such a bug, it will be easier to use
git-bisect
to figure out what’s going on if these two big changes are in separate commits.
Do you mean #129?
Converting non-English messages may break them in game. Need test it on runtime.
@winterheart How can I start D3 in a specific language?
Converting non-English messages may break them in game. Need test it on runtime.
@winterheart How can I start D3 in a specific language?
I think it uses your system language.
- I recommend putting
fixes #145
into the description of this pull request so that that issue automatically gets closed when this PR is merged.- I think that you should split this change into two different commits, one that converts things to UTF-8, and one that switches to LF line endings. We may find a bug in the future that is caused by switching to UTF-8, but not caused by switching to LFs. If we do end up finding such a bug, it will be easier to use
git-bisect
to figure out what’s going on if these two big changes are in separate commits.Do you mean #129?
Yes.