Descent3
Descent3 copied to clipboard
DescentDevelopers
Fixed Release build
This adds the missing preprocessor define RELEASE in Release builds.
This is related to #110, but still has problems in windowed mode (start menu screen and videos not in correct resolution).
I don't know if it's my previous settings causing this, but it doesn't seem quite right.
That's why I wrote "but still has problems in windowed mode (start menu screen and videos not in correct resolution)." Ingame resolutions looks ok.
And there seems to be more inconsisties between #ifndef RELEASE and #ifdef _DEBUG that only work on Windows.
That's why I wrote "but still has problems in windowed mode (start menu screen and videos not in correct resolution)." Ingame resolutions looks ok.
And there seems to be more inconsisties between #ifndef RELEASE and #ifdef _DEBUG that only work on Windows.
Ingame runs fine, yes, but the ingame ui does not work well, putting the game in a less playable state in window mode. I think this is better accomplished by #121. The caveat here is that #121 only works on Windows, and I think this is supposed to function on all platforms?
That's why I wrote "but still has problems in windowed mode (start menu screen and videos not in correct resolution)." Ingame resolutions looks ok. And there seems to be more inconsisties between #ifndef RELEASE and #ifdef _DEBUG that only work on Windows.
Ingame runs fine, yes, but the ingame ui does not work well, putting the game in a less playable state in window mode. I think this is better accomplished by #121. The caveat here is that #121 only works on Windows, and I think this is supposed to function on all platforms?
This started out to just add the missing preprocessor define for RELEASE, which just happens to be related to the window mode. But with all the additional problems and breaking Linux/Max builds, that I can't test locally right now, this might better be closed for now. I haven't looked at #121 or why that only works for Windows.
That's why I wrote "but still has problems in windowed mode (start menu screen and videos not in correct resolution)." Ingame resolutions looks ok. And there seems to be more inconsisties between #ifndef RELEASE and #ifdef _DEBUG that only work on Windows.
Ingame runs fine, yes, but the ingame ui does not work well, putting the game in a less playable state in window mode. I think this is better accomplished by #121. The caveat here is that #121 only works on Windows, and I think this is supposed to function on all platforms?
This started out to just add the missing preprocessor define for RELEASE, which just happens to be related to the window mode. But with all the additional problems and breaking Linux/Max builds, that I can't test locally right now, this might better be closed for now. I haven't looked at #121 or why that only works for Windows.
I appreciate the effort, it will no doubt help others know where to look. #121 only works on Windows because the submitter hasn't been able to add the needed code for other platforms.
Can we reopen this with my latest changes to the branch?
I found the problem with the inconsistent Linux/Mac builds. _DEBUG was always active for them, even in Release build. I testet this on my fork with a modified GitHub workflow file to allow executing the build actions for all branches. Which now all pass: https://github.com/pzychotic/Descent3/actions/runs/8773558703
I also made a workaround to keep the old behavior regarding #110.
Can we reopen this with my latest changes to the branch?
I found the problem with the inconsistent Linux/Mac builds. _DEBUG was always active for them, even in Release build. I testet this on my fork with a modified GitHub workflow file to allow executing the build actions for all branches. Which now all pass: https://github.com/pzychotic/Descent3/actions/runs/8773558703
I also made a workaround to keep the old behavior regarding #110.
There's not really a need for that workaround at the moment. #110 was closed due to the proposed merge branch being removed. We are contemplating moving over to a gitflow strategy, which we think will help with multiple forks trying to achieve a similar goal.
I'm not quite sure that I correctly understand your comment. Do you mean my workaround for window mode changes are not required if we take the rest of this PR?
Just in case my description of why we want this PR weren't quite clear: Right now we create Release builds with a lot of debug code, because RELEASE was never set on any platform. And additionally on Linux/Mac _DEBUG was set even for Release build. Correcting these build problems leads to the problem you posted above in the screenshots. So my workaround just keeps the current state with the fixed resolution of 640x480 in window mode. I haven't had the chance to look deeper into it to correctly fix window mode.
I'm not quite sure that I correctly understand your comment. Do you mean my workaround for window mode changes are not required if we take the rest of this PR?
Just in case my description of why we want this PR weren't quite clear:
Right now we create Release builds with a lot of debug code, because RELEASE was never set on any platform. And additionally on Linux/Mac _DEBUG was set even for Release build.
Correcting these build problems leads to the problem you posted above in the screenshots. So my workaround just keeps the current state with the fixed resolution of 640x480 in window mode.
I haven't had the chance to look deeper into it to correctly fix window mode.
Your workaround isn't required, right. It's my opinion that windowed mode was going to be a 1.5 feature that didn't come out of debugging. I see two options: disable it in release or complete the intention (perhaps still restrict its resolution but allow it to be dragged and function as a window instead of the viewpoint currently is). Further optimizations like resizing windows is a modernization that should come after 1.5 release.
I'm not quite sure that I correctly understand your comment. Do you mean my workaround for window mode changes are not required if we take the rest of this PR? Just in case my description of why we want this PR weren't quite clear: Right now we create Release builds with a lot of debug code, because RELEASE was never set on any platform. And additionally on Linux/Mac _DEBUG was set even for Release build. Correcting these build problems leads to the problem you posted above in the screenshots. So my workaround just keeps the current state with the fixed resolution of 640x480 in window mode. I haven't had the chance to look deeper into it to correctly fix window mode.
Your workaround isn't required, right. It's my opinion that windowed mode was going to be a 1.5 feature that didn't come out of debugging. I see two options: disable it in release or complete the intention (perhaps still restrict its resolution but allow it to be dragged and function as a window instead of the viewpoint currently is). Further optimizations like resizing windows is a modernization that should come after 1.5 release.
Ok, I reverted the workaround and disabled window mode in Release builds for now. If I find time on the weekend I might look deeper into the window mode stuff, outside of this PR.