Derek Lewis

Results 81 comments of Derek Lewis

> Using potentially shared fixture directories would make that easier than to put the file contents inside of the data structure though. 👍 > I think there's a misunderstanding about...

I must admit, I've been a bit stumped on this issue due to its massive/unclear scope. I would need clarity on what module specifier resolution we should be testing? Here...

Using JSON for this isn't going to work due to needing to constantly escape the quotes needed for module specifiers. We need a new data interchange format. YAML is perfect...

> TOML, even. If I'm not mistaken, TOML uses quotes too, so we would have the same problem as we have with JSON.

In https://github.com/nodejs/modules/issues/472#issuecomment-584994986 there is a `files.content` that is supposed to contain actual module source text. Escaping all quotes there will inaccurately portray reality.

I think it would be best to keep that as a `.mjs` file using a template literal for the value of the `files.content` key (just have to escape backticks if...

A couple more test cases to add: - [Windows UNC paths](https://docs.microsoft.com/en-us/dotnet/standard/io/file-path-formats#unc-paths) (leading `\\`) - [Protocol-relative URL](https://www.paulirish.com/2010/the-protocol-relative-url/) (leading `//`)

@GeoffreyBooth, I am not confident that your idea about chaining is solid, and it still has not been presented, so please try not to make your proposed chaining a constraint...

> […] it was the reason @JakobJingleheimer spent months on the consolidation PR. The reason for the consolidation was because the way we had the hooks before was illogical. That...

- https://www.w3.org/TR/webarch/#def-coneg - https://www.w3.org/2001/tag/issues.html#contentTypeOverride-24