DerToaster98 comments

Results 16 comments of


                                            DerToaster98

Change SignTranslateEvent to use Adventure

> > Alright, do you mind if i use my "adapter" that i already have within the PR then? > > Sure, but put in some comments mentioning that when...

[Feature] Sign rework api (part 1 of 2 for sign rework PR)

> I did an initial look through, to properly understand the `AbstractMovecraftSign` I think I'll need to try my hand at updating a sign or two. For examples on the...

[Feature] Sign rework api (part 1 of 2 for sign rework PR)

Adressed your points

[Feature] Sign rework api (part 1 of 2 for sign rework PR)

PR is ready for new review, it is now at the same state as my own testing branch which is being run since 2 weeks on a different server and...

[Feature / Cleanup] Sign rework (WIP)

> > ``` > > * [ ] **NEW** Subcraft Move > > ``` > > This would be best left for a separate PR. I believe there are many...

[Feature / Cleanup] Sign rework (WIP)

> I've not gotten even an understanding of how this PR works yet, but I have a few comments on the first few files I've looked through. Github says there...