ms-seo icon indicating copy to clipboard operation
ms-seo copied to clipboard

seoByRouteName is bogging down my app

Open queso opened this issue 9 years ago • 14 comments

I am not using the seoByRouteName for any actual data, is there a way we can make it optional?

I am talking about this line of code: https://github.com/DerMambo/ms-seo/blob/66717dd1f8d08c8cb6faadf7545ae123c6e440e8/seo.coffee#L167.

/cc @sachag

queso avatar Sep 15 '15 22:09 queso

This is having a large impact on crater.io performance

queso avatar Sep 15 '15 22:09 queso

+1

jeffpatzer avatar Oct 14 '15 22:10 jeffpatzer

+1

I actually get the following error consistently:

Exception from sub seoByRouteName id wcAbrwLvTPY6qMMM9 ReferenceError: check is not defined

Not sure if this is because I'm not using seoByRouteName or something else.

kartikTT avatar Nov 12 '15 19:11 kartikTT

Got the same problem (check undefined) which is kind of blur as check is supposed to be part of Meteor.JS documentation...

Deisss avatar Nov 19 '15 14:11 Deisss

+1

quanglam2807 avatar Dec 07 '15 10:12 quanglam2807

+1

jasenkoh avatar Dec 13 '15 14:12 jasenkoh

+1

adeshpandey avatar Dec 18 '15 09:12 adeshpandey

+1

barratt avatar Dec 19 '15 00:12 barratt

+1

yhoiseth avatar Dec 26 '15 22:12 yhoiseth

+1

gabrielmedina avatar Feb 02 '16 19:02 gabrielmedina

+1

hobbyexplorer avatar May 14 '16 03:05 hobbyexplorer

Try this on your meteor app folks:

meteor add check
meteor add ejson

That worked for me.

hobbyexplorer avatar May 14 '16 03:05 hobbyexplorer

+1 Removed this because it was far too inefficient. App CPU was jumping around all the time and hitting 100% sometimes especially under heavy traffic. After I removed this app CPU dropped to a steady 5-10% and hitting a max of 20% consistently. It did also have the highest throughput on my app due to it loading every page with an average of 3,500 page views per day.

aedanmcgarry avatar Jul 29 '17 08:07 aedanmcgarry

+1

guillim avatar Oct 31 '17 12:10 guillim