rl_games icon indicating copy to clipboard operation
rl_games copied to clipboard

Migrate brax v2 in notebook brax_training

Open gonzalesMK opened this issue 1 year ago • 3 comments

Hi!

I just tried to use this notebook: https://github.com/Denys88/rl_games/blob/master/notebooks/brax_training.ipynb and an import error occurred on this:

from brax import jumpy as jp

It seems brax has a new api (v2), and I fixed changing to this:

from brax.v1 import jumpy as jp

gonzalesMK avatar Aug 11 '24 14:08 gonzalesMK

Thanks @gonzalesMK for the finding! Could you please create a PR with the fix? Also hopefully their API is much more stable now I can take a look again into updating to the latest v2.

ViktorM avatar Aug 12 '24 23:08 ViktorM

Sure! I can do that.

gonzalesMK avatar Aug 17 '24 10:08 gonzalesMK

We are working on our own update with Brax support. Thanks for feedback.

Denys88 avatar Dec 11 '24 07:12 Denys88