Class name is not consistent with naming convention

Open Saloshp opened this issue 6 years ago • 4 comments

https://github.com/Dentosal/python-sc2/blob/608bd25f04e89d39cef68b40101d8e9a8a7f1634/examples/terran/onebase_battlecruiser.py#L9

Apr 22 '19 13:04 Saloshp

What do you mean? It does follow it. https://www.python.org/dev/peps/pep-0008/#class-names

Apr 24 '19 15:04 Matuiss2

He means that the OneBaseBattleCruiserBot is called ProxyRaxBot, that would be my guess.

Apr 24 '19 15:04 BurnySc2

@Matuiss2, @BurnySc2 is correct, sry for the unclear description, May I open a PR for these small types of bugs?

Apr 24 '19 16:04 Saloshp

Yes, please use the develop branch for the PRs.

Apr 24 '19 17:04 BurnySc2