summernote-cleaner
summernote-cleaner copied to clipboard
DennisSuitters
A TODO List of Summernote features requests or additions to abstract into this plugin.
- Generated HTML contains all kinds of inline styles
- https://github.com/summernote/summernote/issues/439
- Validate HTML
- https://github.com/summernote/summernote/issues/953
Hi @3nd, not as of yet, it is something I'm planning on doing, spending more time on updating all the plugins. Unfortunately, life and my wife's health issues have meant time away from all of my projects. Haven't even had time to do any woodturning, but I want to get back into things, I haven't abandoned anything, and I am more than happy to accept help and contributions, I just haven't had time to sit down and code.
Hi @DiemenDesign ! I hope everything is going better for you now. Have you had any luck on the "Validate HTML" project?
Been really busy on the Farm lately, I'm hoping once a few things are fixed with the main project are done that I can finally work on things. Stupid life getting in the way.
Nice project! Can we add a setting to keep emodjis? Now they are replaced with ImagePlaceholder and I don't know how to make them possible.
Hi @DiemenDesign, great to see a fellow Tasmanian, thanks for this project!
I have a change that is extracting the body content before the rest of the cleaning is done, this gets rid of a lot of odd tags that Word is now including when pasting a full document in, along with meta and link tags. I'm also stripping empty tags, which seems to remove Office namespaced 'p' tags as a bonus. Are either of these any use in the module? Currently only implemented in the JQuery function.
Cheers!
Hey Geoff, not many of us Taswegians on here, well you're the only other one it seems, lol. Where about in Tassie are you located? I'm in Gawler, just outside Ulverstone.
I have to sit down and work out what's going on with the plugin. I tested and merged some PR's last night, and noticed it's removing everything, I figured something must have changed in the markup of word documents.
Thanks for looking at this. I look forward to your contributions, and getting it to work again.
Hi Dennis, I'm in Chudleigh, just west of Deloraine, so around the corner, sort-of!
It is currently working for me, and it's a life-saver for our purposes! At this stage I have some tweaks that are making it more suitable for my needs, but this won't mean the changes are applicable for everyone I guess. I do have an additional fix on the way as the display of character count disappears after a cleaning operation.
Ah nice, and nice area over that way.
Perhaps I need to investigate some more on my end, maybe something external to the plugin is stopping it from working correctly. I've been more concerned about adding Analytics to the CMS I've built for clients and adding an Agronomy feature mostly for my own use, to manage our farm and livestock record keeping.
Hi Dennis,
To be clear, it is working now that the return statements have been added in, so no fundamental problems.
Any further modifications I'm putting through are to remove a bit of extra cruft that the JQuery function is missing, ie. current PR for the span wrapping on span removal and similar to come. Fix for the status reporting character count, this is only ever set in the init function, as soon as the plugin reports that it has cleaned it clears the status bar but doesn't restore the character count.
I noticed the agronomy feature when having a browse, nice CMS too! I think I'm up to attempt 10 or 16 on farm record management software, but the day job drains the enthusiasm :/
@DiemenDesign My apologies, I have noticed that the source of Word head tags being left after a clean was an incomplete list of badTags in my setup script, compared to the defaults.
I hadn't noticed, but I didn't test extensively. I'm currently working on adding a Roster system to my CMS, so a little distracted with that, being implemented in light of the recent Employer Contact Gov policy that's being implemented.
Which policy is that? It sounds like something I should be aware of, lol!
I forget what it's called exactly, but it's supposed to stop employers from contacting employees outside of work hours. I've been discussing it a bit on Twitter, with some, well, idiots (to be kind), in that is what happens when someone calls in sick and creates a situation where the employer has to find someone to work at short notice. However, there are allowances for that, where workers can opt-in to be contacted for set reasons, such as staff shortages. Personally, I think it should be in work agreements that employees can make choices if they want to be contacted, with a list of possible reasons. I know when I worked for my father's business with multiple staff, we would contact employees that are likely to not have family commitments outside of work hours first, and if they were no available at short notice, then others would be contacted, unless those people specifically told us it was ok to call on them if short staffed. lol, I guess some use work as an excuse to get away from family. I think the Government is just trying to be progressive unnecessarily with this, rather than addressing more important issues, like the cost of living, and refusing to RC's into things like where tax payer money is being used (aka Jacinta Price's request, what are they hiding).