Account for conflicting plugin names
Reported on Discord.
Addtions
Depenizen.BridgeDatarecord - just holds a bridge supplier & the new class checks.- new
registerBridgeoverload that takes aclassCheck.
Changes
allBridgesnow stores the newBridgeData, and all relevant methods take/pass it.bridgeData.classCheckis now checked inloadBridgeif it exists, and stops loading the bridge if the class isn't found.- The
Questsbridge now has a class check ofme.pikamug.quests.Quests.
I don't know if I agree with this check - there should be an error here, a plugin registered itself with the same name as a pre-existing decently well known plugin, that is obviously erroneous behavior. It should be a big shiny red error, telling you somebody fucked up, because they absolutely did. That said, the original discord report had like 5 duplicate stack traces in a row, and that's a bit excessive. It should just be one clear error, not a cascade. A shiny red glare in the startup logs, not a clusterfuck.
I don't know if I agree with this check - there should be an error here, a plugin registered itself with the same name as a pre-existing decently well known plugin, that is obviously erroneous behavior. It should be a big shiny red error, telling you somebody fucked up, because they absolutely did. That said, the original discord report had like 5 duplicate stack traces in a row, and that's a bit excessive. It should just be one clear error, not a cascade. A shiny red glare in the startup logs, not a clusterfuck.
Changed it to an error message, lmk if that looks good.