Depenizen icon indicating copy to clipboard operation
Depenizen copied to clipboard

Account for conflicting plugin names

Open tal5 opened this issue 1 year ago • 1 comments

Reported on Discord.

Addtions

  • Depenizen.BridgeData record - just holds a bridge supplier & the new class checks.
  • new registerBridge overload that takes a classCheck.

Changes

  • allBridges now stores the new BridgeData, and all relevant methods take/pass it.
  • bridgeData.classCheck is now checked in loadBridge if it exists, and stops loading the bridge if the class isn't found.
  • The Quests bridge now has a class check of me.pikamug.quests.Quests.

tal5 avatar Oct 23 '24 08:10 tal5

I don't know if I agree with this check - there should be an error here, a plugin registered itself with the same name as a pre-existing decently well known plugin, that is obviously erroneous behavior. It should be a big shiny red error, telling you somebody fucked up, because they absolutely did. That said, the original discord report had like 5 duplicate stack traces in a row, and that's a bit excessive. It should just be one clear error, not a cascade. A shiny red glare in the startup logs, not a clusterfuck.

mcmonkey4eva avatar Oct 23 '24 16:10 mcmonkey4eva

I don't know if I agree with this check - there should be an error here, a plugin registered itself with the same name as a pre-existing decently well known plugin, that is obviously erroneous behavior. It should be a big shiny red error, telling you somebody fucked up, because they absolutely did. That said, the original discord report had like 5 duplicate stack traces in a row, and that's a bit excessive. It should just be one clear error, not a cascade. A shiny red glare in the startup logs, not a clusterfuck.

Changed it to an error message, lmk if that looks good.

tal5 avatar Jan 12 '25 18:01 tal5