Added Strays to the `should_burn` property

Open heypr opened this issue 1 year ago • 1 comments

Very small PR.

Aug 02 '24 16:08 heypr

LGTM, but should test on 1.17 before merge - looks like the methods where a bit different back then so just make sure it all works

Aug 31 '24 13:08 tal5

Did you perform the testing Aya requested yet?

Dec 23 '24 09:12 mcmonkey4eva

Did you perform the testing Aya requested yet?

Yes, it functions the same on 1.17.

Dec 23 '24 09:12 heypr

Did you perform the testing Aya requested yet?

Yes, it functions the same on 1.17.

Are you sure? from some testing it seems to throw a NoSuchMethod for AbstractSkeleton#shouldBurnInDay when trying it on a skeleton on 1.17, but I might be doing something wrong?

Dec 24 '24 20:12 tal5

Did you test that change? It doesn't seem to address the error Aya reported above

Feb 06 '25 09:02 mcmonkey4eva

Did you test that change? It doesn't seem to address the error Aya reported above

Forgot to change the bottom part before, but yeah I've tested it (properly this time lol) and it works as intended.

Feb 07 '25 15:02 heypr

You've removed an earlier change that had no reason to remove that I can see, and reactivated my earlier comment

Feb 09 '25 12:02 mcmonkey4eva