ExtendedHotbar icon indicating copy to clipboard operation
ExtendedHotbar copied to clipboard

Hotbar curser disappears when scrolling outside of standard range in fluent mode. (Mod Incompatibility)

Open HB-Stratos opened this issue 1 year ago • 5 comments

As the title says, I'm trying the mod in fluent mode, and I'd quite like to use it. But as it is now, it is unusable as the outer parts of both hotbars have the curser disappear.

https://github.com/DenWav/ExtendedHotbar/assets/56313836/1490ee57-dcbe-4152-8372-b71750213fd7

here's a log: 06AIGmm.txt version 1.20.1 fabric with extended hotbar 3.0.0

This appears to be some sort of mod incompatibility as the issue does not occur if I test it on an empty modpack.

HB-Stratos avatar May 17 '24 15:05 HB-Stratos

Found the culprit. Smoothscroll breaks the fluent hotbar here. disabling smooth scroll hotbar (by setting the animation to zero) fixes the issue

HB-Stratos avatar May 17 '24 15:05 HB-Stratos

Alright, will take a look, thanks for the report.

DenWav avatar May 17 '24 21:05 DenWav

I have a workaround that fixes it halfway, at least making it usable, but I can't figure out how to do a full fix due to the mod calling rendering functions inside of a @ModifyArgs method, which is a pretty bad abuse of Mixins. If that was done as an inject instead I might be able to implement a workaround.

DenWav avatar May 18 '24 22:05 DenWav

hi... how would you like me to do this? the main function of the rendering functions is to render the selector on both sides of the hotbar when it is "rolling over" (going out of bounds)... i need the arguments of the rendering method to account for other mods changing them (like your mod presumably does) i'm also going to implement a sort of half fix which is going to improve other potential mod compatibility issues by disabling the mask when the selector is stationary...

SmajloSlovakian avatar Jun 04 '24 15:06 SmajloSlovakian

for now, i've made a commit to the dev branch, where i cut out the draw calls from the mixin into a different class you can mixin into to potentially fix the issue... hope this helps... if you have any questions or requests, please tell

SmajloSlovakian avatar Jun 05 '24 16:06 SmajloSlovakian