old_dapp icon indicating copy to clipboard operation
old_dapp copied to clipboard

implement getter to fetch ballot creation info from Ethereum and IPFS

Open virgile-dev opened this issue 7 years ago • 9 comments

Ballot information that we need to query:

  • [x] title
  • [ ] author name
  • [x] date of creation
  • [x] transaction status

The transaction status is only needed when the user creates the ballot. I'm thinking to construct the page we don't really have to get title, author name, date of creation if we just cache them and construct the page with the info. That way the only getter we'd need would be the transaction status. What do you think @LucasIsasmendi @aecc ?

virgile-dev avatar Apr 22 '18 10:04 virgile-dev

The ballot page when just created: capture d ecran 2018-04-22 a 12 48 03

virgile-dev avatar Apr 22 '18 11:04 virgile-dev

If the proposed changes are implemented in https://github.com/DemocracyEarth/contracts/issues/51 I think this issue is redundant right?

AlexJupiter avatar May 08 '18 19:05 AlexJupiter

Still the we need to implement fetching title, author, date from the blockchain. I'll be working on this soon

aecc avatar May 14 '18 19:05 aecc

title, author and date are not coming from IPFS?

LucasIsasmendi avatar May 14 '18 20:05 LucasIsasmendi

yes, I meant from IPFS, through the blockchain first. As I see only author name is missing. The rest, title and date seem implemented

aecc avatar May 23 '18 21:05 aecc

@aecc @LucasIsasmendi there seem to be some duplicates of the points here in https://github.com/DemocracyEarth/dapp/issues/49, should this issue be closed and we just refer to #49 ?

Also, is this in "in progress", and if so, which one of you is working on this?

AlexJupiter avatar May 29 '18 17:05 AlexJupiter

There is a pending "author name" implementation, the trick here is if we should rely on IPFS or ETH for that. But yes, we can close this because we changed the view model of this ballot detail page

LucasIsasmendi avatar May 29 '18 18:05 LucasIsasmendi

@AlexJupiter @LucasIsasmendi I thought the #49 was a pure UI or UX task. There is work to do about the author unrelated to UX. @LucasIsasmendi as you already closed the issue, wanna add it somewhere else so it's not forgotten?

aecc avatar May 29 '18 19:05 aecc

You are right @aecc , reopening this to complete pending task

LucasIsasmendi avatar May 29 '18 21:05 LucasIsasmendi