old_dapp icon indicating copy to clipboard operation
old_dapp copied to clipboard

Style ballot dashboard page

Open virgile-dev opened this issue 7 years ago • 12 comments

Parent #69

THE BALLOT

  • [x] Layout CSS
  • [x] Style to designs
  • [x] Get a ballot title
  • [ ] Get posted by
  • [ ] Add time stamp for posted date
  • [x] vote % on yes and no
  • [x] vote data on yes and no
  • [ ] get cast votes data
  • [ ] get number of undecided votes data

YOUR ACTION

  • [x] Layout CSS
  • [ ] Style to designs
  • [ ] Add tooltip
  • [x] vote tab and delegation tab
  • [ ] radio buttons for yes and no options
  • [x] vote button
  • [ ] revoke vote button
  • [ ] get list of potential delegates in dropdown
  • [ ] You delegated x votes to [user] for this ballot
  • [ ] revoke delegation button
  • [ ] transaction status

LIQUID DEMOCRACY REPRESENTATION

  • [x] Layout CSS
  • [ ] Style to designs
  • [ ] add tooltip
  • [x] add tabs
  • [x] vote graph for yes
  • [ ] vote graph for no
  • [ ] vote graph for undecided

See #57 for delegate tab.

virgile-dev avatar Apr 22 '18 10:04 virgile-dev

Vote on ballot capture d ecran 2018-04-22 a 15 25 02

Revoke delegation on ballot capture d ecran 2018-04-22 a 15 21 16

virgile-dev avatar Apr 22 '18 13:04 virgile-dev

New designs for this: https://www.figma.com/file/Eo76kM4frkNFRBjvtvGKCNqc/Sovereign-UI-toolkit?node-id=846%3A0

image

AlexJupiter avatar May 19 '18 18:05 AlexJupiter

Looks amazing

aecc avatar May 23 '18 21:05 aecc

@LucasIsasmendi now I've made progress with the design system, I'll be able to crack on with some of these points above this week. Are the above completed/in-completed tasks above still accurate with your side?

AlexJupiter avatar May 29 '18 17:05 AlexJupiter

@LucasIsasmendi do you know why the active tab state isn't working?

AlexJupiter avatar Jun 01 '18 15:06 AlexJupiter

No idea, we need more front end power

LucasIsasmendi avatar Jun 01 '18 15:06 LucasIsasmendi

@AlexJupiter @LucasIsasmendi could you guys elaborate on the issue here? Trying to debug

medied avatar Jun 07 '18 20:06 medied

@medied are you are to click on the delegates tab, on the ballot dashboard, to see the list of delegates?

When I click on "delegate" this is the error I see: image

AlexJupiter avatar Jun 08 '18 07:06 AlexJupiter

@AlexJupiter was able to replicate that tab behavior and fixed it with c8b2e1a630a8d1e92d16660919487168ac42f875. Looks like it was originally set correctly with 35fba64ed8617cccab68ee366d4feaa4b6e626ee but got messed up with 3c3eb12d930941928163723b6a051c6c7bb30587.

Does this resolve the blocker for you? Seems there are some thing things that are still broken with ballot-dashboard but I'm actually not sure because I'm likely out of context. Let me know though, if there are more bugs indeed we should list them out as separate issues. Thinking we could probably benefit from a brief 15-minute video call with @LucasIsasmendi just to sort this stuff out.

medied avatar Jun 11 '18 15:06 medied

@medied apologies about the delayed reply, however I think I said this in the catchup on Monday, you've resolved my blockers. So thank you!

AlexJupiter avatar Jun 16 '18 21:06 AlexJupiter

@medied I'm also struggling with https://github.com/DemocracyEarth/dapp/issues/95 that needs to be completed for this issue to be closed. Would you be able to help me with this?

AlexJupiter avatar Jun 16 '18 21:06 AlexJupiter

Low on bandwidth this week

medied avatar Jun 18 '18 20:06 medied