ShutdownTimer icon indicating copy to clipboard operation
ShutdownTimer copied to clipboard

Show minutes

Open galen1423 opened this issue 2 years ago • 4 comments

Hello,

First of all, many thanks for this essential application for me, it does me a lot of service.

I don't know if it's bug or feature or intentional , but I notice that top panel time left doesn't show minutes, only hours... Would it be possible to display the remaining time with hours and minutes?

Thanks again for your work.

Regards

galen1423 avatar Sep 28 '23 11:09 galen1423

I don't know if it's bug or feature or intentional

This is intentional. It shows a short duration string: for >=3 hours it only shows hours, for >=1 minutes only minutes, and then seconds. If you are interested in improving this or having an option that changes this, please be specific in describing this potential new feature.

Here is the code: https://github.com/Deminder/ShutdownTimer/blob/40a9795cf90424cbbb25311d8244fd608d5200f3/src/modules/schedule-info.js#L112-L128

Deminder avatar Sep 28 '23 13:09 Deminder

I was thinking a something simple display with maybe option to show or not seconds and/or minutes... maybe like that: 03:22:51 03:22 03

The running app in default mode could be H:M:S

If time > 1 hour then display Hour:Minutes:Seconds If time < 1 hour then display Minutes:Seconds if time < 1 minutes then display Seconds

galen1423 avatar Sep 28 '23 14:09 galen1423

I think, showing a more exact duration HH:mm or HH:mm:ss in the indicator text makes sense as an option. However, could you describe why showing the seconds with minutes >= 1 or even hours >= 1 could be useful? In most cases, I image this just being anoying.

if time < 1 minutes then display Seconds

Wouldn't showing 21 secs instead of 21 make more sense?

How about making an option to display like this instead? 03:22:51 displayed as 03:22 (HH:mm if hour >= 1) 00:22:51 displayed as 22:51 (mm:ss, otherwise)

Deminder avatar Sep 28 '23 18:09 Deminder

Sure, it can display only two fields but maybe some people would like to be able to display the seconds too... Hence the idea of offering an option to display or not the seconds and/or minutes. For those who only want the hours, they can display only the hours. For those who want more precision, they can display minutes and/or seconds.

It remains to be determined whether the "finished" fields disappear from view or whether all fields, even finished, remain visible.

Example for 20 minutes 45 seconds left: 00:20:45 or only field 20:45 Example for 45 seconds left: 00:00:45 or only field 45

I have no idea how difficult or not to do this because I don't code... I don't have the talent for it. ^^

galen1423 avatar Sep 28 '23 19:09 galen1423