Datatypes

[xldeltares]

add as type and rearrange dataadaptor get_data function orders.

[codecov-commenter]

Codecov Report

Merging #55 (89314f9) into main (a3f5dc1) will decrease coverage by 0.30%. The diff coverage is 35.48%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   77.38%   77.08%   -0.31%     
==========================================
  Files          21       21              
  Lines        3547     3574      +27     
==========================================
+ Hits         2745     2755      +10     
- Misses        802      819      +17     

Impacted Files	Coverage Δ
hydromt/data_adapter.py	77.13% <35.48%> (-1.93%)	:arrow_down:
hydromt/io.py	94.87% <0.00%> (-0.08%)	:arrow_down:
hydromt/raster.py	96.49% <0.00%> (+0.12%)	:arrow_up:
hydromt/models/model_api.py	92.34% <0.00%> (+0.19%)	:arrow_up:
hydromt/merge.py	62.50% <0.00%> (+1.94%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3f5dc1...89314f9. Read the comment docs.

[DirkEilander]

@xldeltares I was wondering if this PR is still relevant and should be finalized or can be closed. If it needs to be finalized can you let me know what still needs to be done (and possibly when you could do this)?

[xldeltares]

@xldeltares I was wondering if this PR is still relevant and should be finalized or can be closed. If it needs to be finalized can you let me know what still needs to be done (and possibly when you could do this)?

Hi @DirkEilander! I don't think it is relevant anymore. The current data adaptor seems to be sufficient for the current development of the delft3dfm plugin (thanks to the sophisticated validation rules in hydrolib-core. Also for some special cases we deal with it in the code). So if no other plugins have such a request, I would agree to close it. :)

[DirkEilander]

Thanks for the feedback @xldeltares. Will close for now. If there are new usecases let us know.