hydromt icon indicating copy to clipboard operation
hydromt copied to clipboard

test with new shapely v2 instead of pygeos

Open DirkEilander opened this issue 2 years ago • 2 comments

With geopandas v0.12, the new shapely v2 is supported and pygeos can be removed. I suggest to create different test environments, one with shapely v1.x and pygeos and one with geopandas>=v0.12 and shapely>-2

see geopandas changelog, shapely migration docs and shapely changlog

DirkEilander avatar Oct 25 '22 06:10 DirkEilander

This now created an AttributeError in our tests, so moving to priority to see the consequences

hboisgon avatar Oct 25 '22 07:10 hboisgon

I fixed the test by testing an error exception on a non-empty geodataframe.

There is a lot places in the code where we test on if gdf.crs is not None. These may be prone to error in case of empty or not properly defined GeoDataFrames.

hboisgon avatar Oct 25 '22 08:10 hboisgon