Deltares
Refactor/init sediment model
This PR refactors the initialization of the sediment model by:
- Removing unused variables
- Removing stubs
- Renaming variables names to more descriptive ones
- Extracting large constructions to a separate function
- Simplifying some logic
A general comment (did not go though the code in detail in yet): what about refactoring of the different structs that are part of the Sediment model? As discussed for the SBM concept we would like to sub-divide long structs in sub-structs, I think this is also applicable for the Sediment concept. Probably good to also ask @hboisgon to review this PR?
A general comment (did not go though the code in detail in yet): what about refactoring of the different structs that are part of the Sediment model? As discussed for the SBM concept we would like to sub-divide long structs in sub-structs, I think this is also applicable for the Sediment concept. Probably good to also ask @hboisgon to review this PR?
I completely agree and this is also what I intend to do. I, however, prefer to implement the changes across multiple PR's instead of one big one. Please refer to the task list in #382 for an overview. Each task will be a separate PR. If you feel that list is incomplete please let me know. You can also add potentially missing steps yourself if you would like to.