Wflow.jl
Wflow.jl copied to clipboard
Refactor modeltype `sediment`
Feature type
Refactor the sediment model, i.e., re-organize the model's code without adding new or removing existing features.
Improvement Description
The initialization of the sediment model takes place in one function (initialize_sediment_model
) of over 140 lines of code.
This is poorly maintainable and should be split up into smaller individual logical steps.
In addition, the parameters used for initializing the sediment model are, currently, stored alongside the parameters of all other models / concepts in wflow.
Sediment model parameters should be extracted into its own parameter Struct
.
The extraction of the sediment model parameters should include the re-coupling of sediment model parameter to other models that require access to sediment model parameters.
see also main issue https://github.com/Deltares/Wflow.jl/issues/351
Implementation Description
No response
Additional Context
No response
Tasks
- [ ] #425
- [ ] #451
- [ ] #453
- [ ] Store sediment model parameters in a separate
Struct
- [ ] Refactor the sediment model to use its own parameter
Struct
instead of theModel
struct - [ ] Remove sediment model parameters from the
Model
struct - [ ] Fix all sediment model parameter access invalidations