Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

xenoarch: remove impossible artifact trigger combinations

Open cmorley191 opened this issue 1 month ago • 5 comments

About the PR

Blacklisted artifacts from having undesired trigger combinations, such as "Low Pressure + High Pressure", or "Low Temperature + High Temperature".

Why / Balance

This was a common criticism of the new xenoarch system, when discussing the system in https://github.com/DeltaV-Station/Delta-v/pull/4640

While technically doable (frezon+welding will give both temperature triggers, and just "be fast" to do the pressure combination), these are impractical trigger combinations.

Merging

The new xenoarch system might be reverted soon, in https://github.com/DeltaV-Station/Delta-v/pull/4640 . Merging this before that would cause merge conflicts.

I'm posting this PR for two reasons: 1. in case we decide to postpone the revert, and also 2. for our reference if we revisit the system in the future.

Technical details

The way this actually works is it blacklists the two triggers from appearing on the same artifact, not just on the same node. Limiting it to the same node would be doable in the code, but way more complicated / hard to review and maintain. Happy to discuss that approach though.

Recommended review order:

  • XenoArchTriggerPrototype.cs
  • triggers.yml
  • XenoArtifactSystem.ProcGen.cs

Media

Difficult to demonstrate visually. I tested it by adding a log-statement in the if-statement, giving details when the blacklist triggered. It does work as intended, blocking one or the other trigger when one of the pair is already present (spawned lots of artifacts to test).

Requirements

  • [X] I have tested all added content and changes.
  • [X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

  • tweak: "Impossible" arti trigger combinations (like low+high pressure) will no longer appear on artifacts.

cmorley191 avatar Nov 24 '25 22:11 cmorley191

1 step closer to peak epi gameplay...

dekigangsta avatar Nov 24 '25 23:11 dekigangsta

So actually, this is very possible, aslong as there's multiple atmospheric chambers and you've got a holoprojector and hardsuit

EDIT:HOLOPROJECTOR, NOT HOLOCAUST

Bonktrauma avatar Nov 26 '25 06:11 Bonktrauma

EDIT:HOLOPROJECTOR, NOT HOLOCAUST

that is such a unfortunate auto-correct, my god

AveriV2 avatar Nov 26 '25 07:11 AveriV2

So actually, this is very possible, aslong as there's multiple atmospheric chambers and you've got a holoprojector and hardsuit

EDIT:HOLOPROJECTOR, NOT HOLOCAUST

jarvis, set the "days since last autocorrect fuckup" counter back to 0

Solaris7518 avatar Nov 26 '25 09:11 Solaris7518

@Toby222 ready for re-review. changes have been re-tested

cmorley191 avatar Nov 26 '25 21:11 cmorley191