DeltaV-Station
Fix crazy Glacier map / atmos alerts map (MountainRock needs to be Wall)
Description
The atmos alerts map (and normal map) for Glacier looks crazy, because MountainRock and other types of rock are not recognized as Walls. In reality, there are very normal air alarm setups across the map, they just render weird on this map.
Technically, this has to do with the Wall Tag, which is searched for in the "WallTags" variable of "SharedNavMapSystem.cs" -- MountainRock does not have this wall tag, so the navmap system thinks they are passable terrain.
Reproduction
Go to glacier, open atmos alerts terminal.
Adding this to the MountainRock prototype roughly fixes the issue (though there are other considerations)
- type: Tag
tags:
- Wall
Additional context
Not sure if adding the Wall tag is the right approach. Does the Wall tag have other functions in the code? Does MountainRock appear on other maps? Are there other wall types that need to be fixed, too? Do the other rocks like AsteroidRocks intentionally not have the Wall tag for some reason relating to their typical salv environment? Does making the MountainRock show on the map cause "spoilers", because "hidden rooms" buried in the rocks are revealed on the map?
My concern with adding the wall tag is whether or not it will mess with the tilewall cmd that mappers use. Currently there are already some "natural" walls that have issues with this (that reminds me I need to make a fix for them....)
Looked into this. It seems our walls have diverged quite a bit from upstream ones. I've assigned myself to the issue. Will work on it over the next week.
@IamVelcroboy Honestly, this seems like a good change.
Does the Wall tag have other functions in the code?
Tags are usually associated with whitelisting, so its definitely safer than components. The only notable whitelisting in the code I saw is that Dragons are whitelisted to devour walls, which I think is a fine concession. If dragon can eat metal, it can eat rocks too.
Does MountainRock appear on other maps?
Arena, west of the bridge, for sure. Lighthouse has some but its not really a part of the station. Arena's air alarms for those maints are garbage, if it has any. Its always spaced. It would be nice to add alarms there.
Are there other wall types that need to be fixed, too?
Probbaly not and honestly, we can deal with them as they pop up.
Do the other rocks like AsteroidRocks intentionally not have the Wall tag for some reason relating to their typical salv environment?
Im guessing because usually rocks are not used for walls on Wizden. Their stations are entirely man-made and not carved into an asteroid. At least, that was my impression when I played Wizden primarily more than a year ago.
Does making the MountainRock show on the map cause "spoilers", because "hidden rooms" buried in the rocks are revealed on the map?
It might yea, but it also might spark curiosity from those who see it on the map and are like "hmm...."
