Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

port vulpkanin upscreams

Open weskified opened this issue 1 month ago • 6 comments

About the PR

Changed the vulp screams from being generic human screams to vulpkanin ones in ss14 upstream (https://github.com/space-wizards/space-station-14/pull/37539).

Why / Balance

Some people doesn't prefer vulps screaming like a human

Technical details

Changed the screams for male/female vulpkanin from MaleScreams and FemaleScreams to VulpkaninScreams in speech_emote_sounds.yml

Media

https://github.com/user-attachments/assets/e2708587-3cd4-4574-aa27-df8e93edc39d

Requirements

  • [x] I have tested all added content and changes.
  • [x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None

Changelog

:cl:

  • add: Ported upstream vulpkanin screams

weskified avatar Nov 18 '25 10:11 weskified

Those sounds appear to be commercially licensed, which means we can't use them

Toby222 avatar Nov 18 '25 10:11 Toby222

upscream...

weskified avatar Nov 18 '25 11:11 weskified

anyways, merged the upstream vulp screams instead of ones from the den, because of that

weskified avatar Nov 18 '25 12:11 weskified

Don't want to start drama but i feel obligated to state this (feel free to delete my comment if needed).

These sounds were removed from upstream because they're actually just foxes screaming while mating. The name of the sound is literally "fox sex". Our kitsune scream are also foxes mating and upstream had a lot of drama and arguing on github over the same thing. This is a bit of an issue, especially on a server that isn't 18+, but also a pretty hotly debated topic. Regardless, It's probably best to not go through the exact same thing upstream is/was (even though our kitsune scream is already this)

Spielern avatar Nov 18 '25 18:11 Spielern

I kinda just cherry picked some of the commits from the upstream PR without even knowing that, and a few minutes later after reopening this merging the upstream ones instead from the den, its apparently.. that, so i might close this PR and make a new one instead, with me having the green light to use the new said effects. (or if i can even get a response from them)

weskified avatar Nov 19 '25 02:11 weskified

making this a draft for now, as there IS issues with the current one and a change might be redone again

weskified avatar Nov 19 '25 11:11 weskified

closing this, i dont think we're able to find any sources that would allow free use and dog screams anywhere in the internet...

weskified avatar Nov 29 '25 14:11 weskified